core(driver): fix protocol timeout being ignored for isolated eval #15826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
connorjclark
commented
Feb 21, 2024
| @@ -120,6 +120,27 @@ describe('.evaluateAsync', () => { | |||
| await expect(evaluatePromise).rejects.toBeTruthy(); | |||
| }); | |||
|
|
|||
| it('uses the specific timeout given (isolation)', async () => { | |||
There was a problem hiding this comment.
this did not actually fail without the fix, b/c sendCommand is mocked so nothing resets _nextProtocolTimeout.
I wasn't sure how to fix the mock test, and didn't want to deal with fixing fake code...
@brendankenny besides nuking mocks wyd?
adamraine
approved these changes
Feb 21, 2024
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when attempting to increase the timeout for
executionContext.evaluatedid not change the timeout used.Only
fetchElementWithSizeInformationis existing code which attempted to set a timeout. In that case, the intention was to wait no more than 250ms. That regressed with #14005